Remove flake-inputs; refactor and split out package #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@virtu would you be willing to take a look? this changes the original module work you did. |
jurraca
force-pushed
the
remove-flake-utils
branch
from
12bb120 to
cf824d2
Compare
jurraca
force-pushed
the
remove-flake-utils
branch
from
cf824d2 to
4310247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides removing a dependency for the project, this refactors the flake to be a bit cleaner.
Using
flake-utilsmakes expressing "for each system" type expression simple, but it also gets in the way of items that don't need this type of expression, such as themodule.nix. Thus we had to define an improper module expression, which makes using the module in another expression more complicated as well.So instead we create
forAllSystemsandnixpkgsForfunctions explicitly. This means a little more involved package expressions, but that hide less from the user. The module can now beimport'ed and it can be used as a module in other machine configurations without extra treatment. I stole this idea from this.I also took the opportunity to split out the main package expression into its own file, for clarity.